Use proper try-with-resources for resources to prevent DoS attacks#75
Open
ferrybig wants to merge 1 commit intovexsoftware:masterfrom
ferrybig:master
Open
Use proper try-with-resources for resources to prevent DoS attacks#75ferrybig wants to merge 1 commit intovexsoftware:masterfrom ferrybig:master
ferrybig wants to merge 1 commit intovexsoftware:masterfrom
ferrybig:master
Conversation
|
The underlying DoS issues have been long fixed with NuVotifier (I don't use any of the networking code from Votifier). I highly recommend using it instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of the code doesn't close its resources in case of errors. If this happens to many times, the server will crash because "to many open files". This is a Denial of Service attack vector as clients can trigger his condition by sending bogus data to Votifer's listening port.